lkml.org 
[lkml]   [2009]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] x86 CPU detection for RDC
    From
    Date
    Mark Kelly <mark@bifferos.com> writes:
    > +{
    > + u16 vendor, device;
    > +
    > + /* RDC CPU is SoC (system-on-chip), Northbridge is always present. */
    > + vendor = read_pci_config_16(0, 0, 0, PCI_VENDOR_ID);
    > + device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID);

    This needs some check first if PCI is even enabled. You can use
    early_pci_allowed() for this or just add a handler in early quirks
    that sets a flag you test here.

    Also I would suggest to not hard code your own email addresses
    in printk (which might go away), but use some list like linux-kernel.

    -Andi

    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2009-08-17 15:47    [W:0.019 / U:0.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site