lkml.org 
[lkml]   [2009]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/7] kfifo: move out spinlock
From
Date
Am Montag, den 17.08.2009, 11:52 +0200 schrieb Andi Kleen:
> > I think the break is not so hard if you believe. All you have to do is
> > to replace or kfifo_get() into kfifo_out_locked() and kfifo_put() into
> > kfifo_in_locked() if you really need the old behavior.
> >
> > The thing is that we get no progress without changes.
>
> One thing that would be good to ensure is that old unconverted code
> gets a clear compile time error, just in case some out of tree
> code uses it.

This is already done.

> Bonus points also for having a short comment in kfifo.h that
> explains how to do the conversion.
>

I can do this on a maintainance patch.

> Other than that I would be all for getting rid of embedded spinlocks
> completely.
>
> -Andi




\
 
 \ /
  Last update: 2009-08-17 11:59    [W:0.046 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site