[lkml]   [2009]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] perf tools: Revert the -Wswitch-enum flag
    -Wswitch-enum warns when a switch statement doesn't handle
    every enum values of a given type.

    But it also warns whn we have a default case where we handle them.
    This forces workarounds like having a rain of ignored enum values
    cases falling down to the default case.

    We want to be sure that every cases are handled (which is what does
    -Wswitch-default), but we don't want to explicitly write what must
    fall down to the default case.

    Signed-off-by: Frederic Weisbecker <>
    Cc: Peter Zijlstra <>
    Cc: Arnaldo Carvalho de Melo <>
    Cc: Mike Galbraith <>
    tools/perf/Makefile | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/Makefile b/tools/perf/Makefile
    index d637aea..c7c2645 100644
    --- a/tools/perf/Makefile
    +++ b/tools/perf/Makefile
    @@ -169,7 +169,7 @@ endif
    # Include saner warnings here, which can catch bugs:
    -EXTRA_WARNINGS = -Wcast-align -Wformat=2 -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers -Wundef -Wvolatile-register-var -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement
    +EXTRA_WARNINGS = -Wcast-align -Wformat=2 -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch-default -Wno-system-headers -Wundef -Wvolatile-register-var -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement

    CFLAGS = $(M64) -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -fstack-protector-all -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS)
    LDFLAGS = -lpthread -lrt -lelf -lm

     \ /
      Last update: 2009-08-16 14:57    [W:0.019 / U:155.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site