lkml.org 
[lkml]   [2009]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] basic perf support for sparc
From
From: Jens Axboe <jens.axboe@oracle.com>
Date: Thu, 6 Aug 2009 09:02:42 +0200

> On Sun, Aug 02 2009, David Miller wrote:
>> From: Jens Axboe <jens.axboe@oracle.com>
>> Date: Wed, 29 Jul 2009 13:25:10 +0200
>>
>> > -#define NR_SYSCALLS 327
>> > +#define NR_SYSCALLS 328
>>
>> When you increase this value, you have to add entries to all of the
>> syscall tables. The syscall dispatch checks against this as a limit,
>> so if you don't explicitly add an entry to all the tables, it's
>> possible to deref garbage past the end of the table and try to jump to
>> it as a syscall.
>
> Oops, missed the 32-bit table. Does the below look better?

You got the native 32-bit table, and the native 64-bit table,
but you missed sparc64's 32-bit compat syscall table :-)

There are two syscall tables in arch/sparc/systbls.S, you only
got the native 64-bit one.

Please fix this up, and the patch is fine with that cured,
so make it a formal submission with commit message and signoffs
thanks!

> I'm assuming that this will happen automatically at some point, instead
> of perf defaulting to building with the same 32/64-bit of the kernel.

Right, it looks like Ingo and co. are going to take care of that.


\
 
 \ /
  Last update: 2009-08-17 03:33    [W:0.081 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site