lkml.org 
[lkml]   [2009]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] perf tools: Put the show mode into the event headers files
    Date
    Annotate and report share the same flags to filter events
    considering their context (kernel, user, hypervisor).

    Both tools have their own definitions of these flags. Factorize
    them in the event headers file.

    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    ---
    tools/perf/builtin-annotate.c | 4 ----
    tools/perf/builtin-report.c | 4 ----
    tools/perf/util/event.h | 6 ++++++
    3 files changed, 6 insertions(+), 8 deletions(-)

    diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
    index 820e7cc..6d75151 100644
    --- a/tools/perf/builtin-annotate.c
    +++ b/tools/perf/builtin-annotate.c
    @@ -22,10 +22,6 @@
    #include "util/parse-events.h"
    #include "util/thread.h"

    -#define SHOW_KERNEL 1
    -#define SHOW_USER 2
    -#define SHOW_HV 4
    -
    static char const *input_name = "perf.data";

    static char default_sort_order[] = "comm,symbol";
    diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
    index e104ed3..05d52ff 100644
    --- a/tools/perf/builtin-report.c
    +++ b/tools/perf/builtin-report.c
    @@ -27,10 +27,6 @@

    #include "util/thread.h"

    -#define SHOW_KERNEL 1
    -#define SHOW_USER 2
    -#define SHOW_HV 4
    -
    static char const *input_name = "perf.data";

    static char default_sort_order[] = "comm,dso,symbol";
    diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
    index fa7c50b..fa2d4e9 100644
    --- a/tools/perf/util/event.h
    +++ b/tools/perf/util/event.h
    @@ -4,6 +4,12 @@
    #include "util.h"
    #include <linux/list.h>

    +enum {
    + SHOW_KERNEL = 1,
    + SHOW_USER = 2,
    + SHOW_HV = 4,
    +};
    +
    /*
    * PERF_SAMPLE_IP | PERF_SAMPLE_TID | *
    */
    --
    1.6.2.3


    \
     
     \ /
      Last update: 2009-08-16 19:59    [W:0.020 / U:0.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site