Messages in this thread | | | Date | Sat, 15 Aug 2009 11:56:38 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH tip 1/1] perf record: Fix typo in pid_synthesize_comm_event |
| |
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Em Fri, Aug 14, 2009 at 03:07:11PM -0400, Valdis.Kletnieks@vt.edu escreveu: > > On Fri, 14 Aug 2009 15:26:32 -0300, Arnaldo Carvalho de Melo said: > > > We were using 'fd' locally, but there was a global 'fd' too, so when > > > converting from open to fopen the test made against fd should be made > > > against 'fp', but since we have that global... > > > > If the kernel was -Wshadow safe by default, this sort of thing > > would happen less often... :) > > I would love to have that kind of problem spotted by the compiler, > but this is no kernel code, the CFLAGS we use is different than > the kernel ones, I guess a patch for tools/perf/ would be gladly > accepted by Ingo, but let him say so :-)
Yeah. We are using -Wall and -Wextra right now - but -Wshadow is not turned on by them.
Does gcc ignore non-existent warnings or do we have to probe them in the Makefile, to support older versions of GCC?
Ingo
| |