| Date | Sat, 15 Aug 2009 11:04:29 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [patch 10/15] add xtime_shift and ntp_error_shift to struct timekeeper |
| |
On Fri, 14 Aug 2009, Martin Schwidefsky wrote: > timekeeper.xtime_nsec += timekeeper.xtime_interval; > - if (timekeeper.xtime_nsec >= (u64)NSEC_PER_SEC << clock->shift) { > - timekeeper.xtime_nsec -= (u64)NSEC_PER_SEC << clock->shift; > + nsecs = (u64) NSEC_PER_SEC << timekeeper.shift;
Minor nit. I made this a separate u64 variable as nsecs is s64 and while this signed/unsigned mismatch is probably not hurting in that context it's still not pretty :)
Thanks,
tglx
|