lkml.org 
[lkml]   [2009]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 02/11] fat: cleanup fat_put_super()
Date
Thomas Gleixner <tglx@linutronix.de> writes:

> unload_nls() can be called with a NULL pointer now. Remove the pointer
> checks and the NULLification of the pointers as the data structure
> which contains the pointers is kfree'd right away.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/inode.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> Index: linux-2.6-tip/fs/fat/inode.c
> ===================================================================
> --- linux-2.6-tip.orig/fs/fat/inode.c
> +++ linux-2.6-tip/fs/fat/inode.c
> @@ -470,19 +470,11 @@ static void fat_put_super(struct super_b
>
> iput(sbi->fat_inode);
>
> - if (sbi->nls_disk) {
> - unload_nls(sbi->nls_disk);
> - sbi->nls_disk = NULL;
> - sbi->options.codepage = fat_default_codepage;
> - }
> - if (sbi->nls_io) {
> - unload_nls(sbi->nls_io);
> - sbi->nls_io = NULL;
> - }
> - if (sbi->options.iocharset != fat_default_iocharset) {
> + unload_nls(sbi->nls_disk);
> + unload_nls(sbi->nls_io);

I don't object to this, however, personally I'd prefer to check NULL
explicitly, including brelse().

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2009-08-14 15:15    [from the cache]
©2003-2011 Jasper Spaans