Messages in this thread | | | Subject | Re: [RFC patch] init default dma_ops to prepare intel_iommu_init failure | From | David Woodhouse <> | Date | Thu, 13 Aug 2009 09:26:12 +0100 |
| |
On Thu, 2009-08-13 at 12:18 +0900, FUJITA Tomonori wrote: > > Duh, yeah, intel_iommu_init() fails, it doesn't work. > > > > X86 falls back into nommu_dam_ops but IA64 has nothing. > > > > pci_swiotlb_init() can't set swiotlb to 1 or overwrite dma_ops? If it > > sets swiotlb to 1, intel_iommu_init() fails. > > > > A quick fix could be something like this: > > Oops, here's a good one.
Closer, but don't we still want to free the swiotlb buffers if the iommu init _does_ actually work?
And we want the same on x86 too -- we want swiotlb, not nommu.
-- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation
| |