Messages in this thread | | | Date | Thu, 13 Aug 2009 16:19:54 +0800 | From | Amerigo Wang <> | Subject | Re: [Patch 0/8] V3 Implement crashkernel=auto |
| |
Bernhard Walle wrote: > Hi, > > * Amerigo Wang <amwang@redhat.com> [2009-08-13 04:49]: > >> Bernhard Walle wrote: >> >>> Honestly I don't see why everything is guarded by >>> CONFIG_KEXEC_AUTO_RESERVE. We do we need that new configuration >>> option? I mean, if I don't specify 'crashkernel=auto', then the patch >>> does nothing, right? Then the option CONFIG_KEXEC_AUTO_RESERVE would >>> only be needed so save some bytes of code. Is that really worth it? >>> >> Hi, CONFIG_KEXEC_AUTO_RESERVE is not for saving bytes, it just >> provides a choice for the user to decide to enable it or not. >> > > Still, I don't understand it. When I don't say "crashkernel=auto" on > command line, then nothing is done, right? So the choice for the user > is the "crashkernel=auto". Why do we need CONFIG_KEXEC_AUTO_RESERVE > then? Maybe I just missed something in my logic ... > Sure.
But if we disable CONFIG_KEXEC_AUTO_RESERVE, that means crashkernel=auto will be invalid, this is the same as it is now.
| |