Messages in this thread Patch in this message | | | Date | Thu, 13 Aug 2009 12:50:18 -0700 | From | Greg KH <> | Subject | [patch 43/74] md: when a level change reduces the number of devices, remove the excess. |
| |
2.6.30-stable review patch. If anyone has any objections, please let us know.
------------------
From: NeilBrown <neilb@suse.de>
commit 3a981b03f38dc3b8a69b77cbc679e66c1318a44a upstream.
When an array is changed from RAID6 to RAID5, fewer drives are needed. So any device that is made superfluous by the level conversion must be marked as not-active. For the RAID6->RAID5 conversion, this will be a drive which only has 'Q' blocks on it.
Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/md/md.c | 7 +++++++ 1 file changed, 7 insertions(+)
--- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2680,6 +2680,7 @@ level_store(mddev_t *mddev, const char * ssize_t rv = len; struct mdk_personality *pers; void *priv; + mdk_rdev_t *rdev; if (mddev->pers == NULL) { if (len == 0) @@ -2759,6 +2760,12 @@ level_store(mddev_t *mddev, const char * mddev_suspend(mddev); mddev->pers->stop(mddev); module_put(mddev->pers->owner); + /* Invalidate devices that are now superfluous */ + list_for_each_entry(rdev, &mddev->disks, same_set) + if (rdev->raid_disk >= mddev->raid_disks) { + rdev->raid_disk = -1; + clear_bit(In_sync, &rdev->flags); + } mddev->pers = pers; mddev->private = priv; strlcpy(mddev->clevel, pers->name, sizeof(mddev->clevel));
| |