Messages in this thread | | | Date | Thu, 13 Aug 2009 13:12:17 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] fs/proc/task_mmu.c v1: fix clear_refs_write() input sanity check |
| |
On Thu, 13 Aug 2009, Amerigo Wang wrote:
> >I did the same to other functions, but Andrew pointed out making changes > >without fully understanding the patch impact would be risky and break > >existing applications, So I need to fully understand what those functions > >do before I make any changes. > > > > > I can't find any strong reason why this one is differernt from others > in accepting input like "1foo"... >
As I already pointed out, there's a patch pending in mmotm that limits the write to either 1, 2, or 3, depending on the type of pages the referenced bit shall be cleared for associated with the task.
The net effect of Vincent's change is to automatically strip whitespace and to remove a needless -EIO error condition at the end of the write handler.
It is rather obvious that Vincent's patch is a clear improvement and your concern is just a waste of bandwidth.
| |