lkml.org 
[lkml]   [2009]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] swap: send callback when swap slot is freed
    (resending in plain text)

    On 08/13/2009 12:23 PM, Peter Zijlstra wrote:
    > On Thu, 2009-08-13 at 08:00 +0530, Nitin Gupta wrote:
    >>> I don't share Peter's view that it should be using a more general
    >>> notifier interface (but I certainly agree with his EXPORT_SYMBOL_GPL).
    >> Considering that the callback is made under swap_lock, we should not
    >> have an array of callbacks to do. But what if this callback finds other
    >> users too? I think we should leave it in its current state till it finds
    >> more users and probably add BUG() to make sure callback is not already set.
    >>
    >> I will make it EXPORT_SYMBOL_GPL.
    >
    > If its such a tightly coupled system, then why is compcache a module?
    >

    Keeping everything as separate kernel modules has been the goal of this
    project. However, this callback is the only thing which I could not do
    without this small patching.

    Nitin


    \
     
     \ /
      Last update: 2009-08-13 16:47    [W:0.019 / U:150.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site