Messages in this thread | | | Date | Thu, 13 Aug 2009 14:02:11 +0800 | Subject | Re: [RFC patch] clean up swiotlb check in intel_iommu_init | From | Luming Yu <> |
| |
>> >> Since swiotlb is an fall back option that might have >> initialized. We don't need to stop intel_iommu_init >> because of swiotlb.. > > I think that this doesn't work on X86; breaks "soft" boot option.
Assumption is that swiotlb is default dma_ops. I got this patch when working on ia64, will check x86 later. But it is only needed when most of us agree that swiotlb should be the default.
> > >> Please review. If make sense, please apply. >> >> **The patch is enclosed in text attachment* >> **Using web client to send the patch* * >> **below is for review, please apply attached patch*/ >> >> Thanks, >> Luming >> >> Signed-off-by: Yu Luming <luming.yu@intel.com> >> >> intel-iommu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c >> index 2314ad7..246acb9 100644 >> --- a/drivers/pci/intel-iommu.c >> +++ b/drivers/pci/intel-iommu.c >> @@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void) >> * Check the need for DMA-remapping initialization now. >> * Above initialization will also be used by Interrupt-remapping. >> */ >> - if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled) >> + if (no_iommu || dmar_disabled) >> return -ENODEV; >> >> iommu_init_mempool(); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |