Messages in this thread | | | Date | Wed, 12 Aug 2009 08:11:30 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [RFC v6][PATCH 0b/4] intel_txt: Intel(R) Trusted Execution Technology support for Linux - Details |
| |
On 08/12/2009 07:53 AM, Ingo Molnar wrote: > * Ingo Molnar <mingo@elte.hu> wrote: > >> i reviewed & tried the latest patches. Structure of v6 looks now >> looks pretty good, but there are some build problems: >> >> arch/x86/kernel/tboot.c: In function ‘tboot_probe’: >> arch/x86/kernel/tboot.c:76: error: implicit declaration of function ‘set_fixmap’ >> arch/x86/kernel/tboot.c:76: error: ‘FIX_TBOOT_BASE’ undeclared (first use in this function) >> arch/x86/kernel/tboot.c:76: error: (Each undeclared identifier is reported only once >> arch/x86/kernel/tboot.c:76: error: for each function it appears in.) >> arch/x86/kernel/tboot.c:77: error: implicit declaration of function ‘fix_to_virt’ >> arch/x86/kernel/tboot.c:77: warning: cast to pointer from integer of different size >> >> config attached. > > ok, hpa fixed this bug - i tested it some more and here's the next > issue: > > arch/x86/built-in.o: In function `tboot_shutdown': > (.text+0x2e3b5): undefined reference to `acpi_wakeup_address'arch/x86/built-in.o: In function `tboot_sleep': > (.text+0x2e679): undefined reference to `acpi_wakeup_address' > > Config attached below. >
tboot_sleep() references acpi_wakeup_address, which is only defined if CONFIG_ACPI_SLEEP is set. We *could* make TBOOT require CONFIG_ACPI_SLEEP, but that looks like the wrong thing to do to me, unless TXT somehow depends on having S3 support.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |