lkml.org 
[lkml]   [2009]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 12/14] scsi: use printk_once
Date

> > - static int vers_printed;
> > -
> > - if (!vers_printed) {
> > - printk(KERN_INFO "%s", version);
> > - vers_printed = 1;
> > - }
> > + printk_once(KERN_INFO "%s", version);

> There's really no point to this beyond code churn. Both patterns are
> correct uses so conversion buys us nothing.

It's a pretty small gain but I do think 6 lines -> 1 line does have value.

- R.


\
 
 \ /
  Last update: 2009-08-11 18:49    [W:0.097 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site