Messages in this thread | | | From | Roland Dreier <> | Subject | Re: [PATCH 12/14] scsi: use printk_once | Date | Tue, 11 Aug 2009 09:46:48 -0700 |
| |
> > - static int vers_printed; > > - > > - if (!vers_printed) { > > - printk(KERN_INFO "%s", version); > > - vers_printed = 1; > > - } > > + printk_once(KERN_INFO "%s", version);
> There's really no point to this beyond code churn. Both patterns are > correct uses so conversion buys us nothing.
It's a pretty small gain but I do think 6 lines -> 1 line does have value.
- R.
| |