lkml.org 
[lkml]   [2009]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perfcounters/urgent] perf_counter: Require CAP_SYS_ADMIN for raw tracepoint data
    Commit-ID:  a4e95fc2cbb31d70a65beffeaf8773f881328c34
    Gitweb: http://git.kernel.org/tip/a4e95fc2cbb31d70a65beffeaf8773f881328c34
    Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
    AuthorDate: Mon, 10 Aug 2009 11:20:12 +0200
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Mon, 10 Aug 2009 11:33:09 +0200

    perf_counter: Require CAP_SYS_ADMIN for raw tracepoint data

    Raw tracepoint data contains various kernel internals and
    data from other users, so restrict this to CAP_SYS_ADMIN.

    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    LKML-Reference: <1249896452.17467.75.camel@twins>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>


    ---
    kernel/perf_counter.c | 8 ++++++++
    1 files changed, 8 insertions(+), 0 deletions(-)

    diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
    index 5229d16..b0b20a0 100644
    --- a/kernel/perf_counter.c
    +++ b/kernel/perf_counter.c
    @@ -3787,6 +3787,14 @@ static void tp_perf_counter_destroy(struct perf_counter *counter)

    static const struct pmu *tp_perf_counter_init(struct perf_counter *counter)
    {
    + /*
    + * Raw tracepoint data is a severe data leak, only allow root to
    + * have these.
    + */
    + if ((counter->attr.sample_type & PERF_SAMPLE_RAW) &&
    + !capable(CAP_SYS_ADMIN))
    + return ERR_PTR(-EPERM);
    +
    if (ftrace_profile_enable(counter->attr.config))
    return NULL;


    \
     
     \ /
      Last update: 2009-08-10 11:41    [W:0.049 / U:60.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site