lkml.org 
[lkml]   [2009]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10/14] infiniband: use printk_once
Date

> drivers/infiniband/hw/cxgb3/iwch.c | 4 +---
> drivers/infiniband/hw/mlx4/main.c | 6 +-----

> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -540,15 +540,11 @@ static struct device_attribute *mlx4_class_attributes[] = {
>
> static void *mlx4_ib_add(struct mlx4_dev *dev)
> {
> - static int mlx4_ib_version_printed;
> struct mlx4_ib_dev *ibdev;
> int num_ports = 0;
> int i;
>
> - if (!mlx4_ib_version_printed) {
> - printk(KERN_INFO "%s", mlx4_ib_version);
> - ++mlx4_ib_version_printed;
> - }
> + printk_once(KERN_INFO "%s", mlx4_ib_version);
>
> mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_IB)
> num_ports++;

Looks fine but there is near-identical code in
drivers/infiniband/hw/mthca/mthca_main.c that you might as well convert
too.

Thanks,
Roland


\
 
 \ /
  Last update: 2009-08-10 07:03    [from the cache]
©2003-2011 Jasper Spaans