lkml.org 
[lkml]   [2009]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: drivers/pci/quirks.c: irq_reroute_variant is dead code?
    [Corrected Stefan's address.]

    On Sat, 8 Aug 2009 16:45:20 +0200
    Ingo Molnar <mingo@elte.hu> wrote:

    >
    > * Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
    >
    > > On Tue, 28 Jul 2009 12:50:08 -0700
    > > Jeremy Fitzhardinge <jeremy@goop.org> wrote:
    > >
    > > > quirk_reroute_to_boot_interrupts_intel() goes to some effort to
    > > > scan for a bunch of Intel devices and set
    > > > dev->irq_reroute_variant = INTEL_IRQ_REROUTE_VARIANT. However,
    > > > as far as I can see that's the only reference to
    > > > dev->irq_reroute_variant and INTEL_IRQ_REROUTE_VARIANT, so the
    > > > whole thing appears to have no effect.
    > > >
    > > > Is it all dead code? Is there something else which should be
    > > > there missing?
    > >
    > > Hm my quick look couldn't find a user either. The initial patch
    > > to add that stuff (e1d3a90846b40ad3160bf4b648d36c6badad39ac) had
    > > an ACPI component, but it looks like that may have vanished
    > > somehow (maybe some of the IOAPIC code got shuffled around and
    > > this bit was missed?).
    > >
    > > Stefan or Ingo?
    >
    > I dont remember ioapic interactions. Stefan?
    >
    > Ingo
    >


    --
    Jesse Barnes, Intel Open Source Technology Center


    \
     
     \ /
      Last update: 2009-08-10 18:35    [W:0.025 / U:0.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site