Messages in this thread | | | Date | Thu, 9 Jul 2009 10:48:40 +0200 | From | Daniel Mack <> | Subject | Re: [PATCH] cpufreq: Unbreak build for !SMP: symlinked cpus cannot happen for !SMP |
| |
On Thu, Jul 09, 2009 at 10:43:35AM +0200, Thomas Renninger wrote: > Or like that: > Either all #ifdef CONFIG_SMP related conditionals to managed cpus > should vanish or all should be covered. This one takes the latter > approach.
Dave Jones fixed it already, see
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5e1596f75395e7a402e1059c518e633d2732dcf8
Daniel
> --- > 'managed_policy' is used for the non-smp case in line 941. > > Make the symlink code conditional to #ifdef CONFIG_SMP as already > done at other places. > > Signed-off-by: Thomas Renninger <trenn@suse.de> > > Index: cpufreq/drivers/cpufreq/cpufreq.c > =================================================================== > --- cpufreq.orig/drivers/cpufreq/cpufreq.c > +++ cpufreq/drivers/cpufreq/cpufreq.c > @@ -930,6 +930,7 @@ static int cpufreq_add_dev(struct sys_de > } > spin_unlock_irqrestore(&cpufreq_driver_lock, flags); > > +#ifdef CONFIG_SMP > /* symlink affected CPUs */ > for_each_cpu(j, policy->cpus) { > if (j == cpu) > @@ -947,6 +948,7 @@ static int cpufreq_add_dev(struct sys_de > goto err_out_unregister; > } > } > +#endif > > policy->governor = NULL; /* to assure that the starting sequence is > * run in cpufreq_set_policy */ >
| |