Messages in this thread | | | Date | Fri, 10 Jul 2009 08:59:57 +0800 | From | Herbert Xu <> | Subject | Re: sk_lock: inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage |
| |
On Thu, Jul 09, 2009 at 05:13:55PM -0700, David Miller wrote: > > I think this specific case needs more thinking. > > If the allocation fails, and it's GFP_ATOMIC, we are going to yield() > (which sleeps) and loop endlessly waiting for the allocation to > succeed.
Indeed. We could do one of the following:
1) Preallocate, either universally or conditinally on sk_allocation. 2) Set a bit somewhere to indicate FIN and retry the allocation as part of retransmit.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |