lkml.org 
[lkml]   [2009]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 41/44] includecheck fix: include/linux, rfkill.h
    From
    Date
    Hi Jaswinder,

    > > > fix the following 'make includecheck' warning:
    > > >
    > > > include/linux/rfkill.h: linux/types.h is included more than once.
    > > >
    > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    > > > ---
    > > > include/linux/rfkill.h | 1 -
    > > > 1 files changed, 0 insertions(+), 1 deletions(-)
    > > >
    > > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
    > > > index e73e242..2ce2983 100644
    > > > --- a/include/linux/rfkill.h
    > > > +++ b/include/linux/rfkill.h
    > > > @@ -99,7 +99,6 @@ enum rfkill_user_states {
    > > > #undef RFKILL_STATE_UNBLOCKED
    > > > #undef RFKILL_STATE_HARD_BLOCKED
    > > >
    > > > -#include <linux/types.h>
    > > > #include <linux/kernel.h>
    > > > #include <linux/list.h>
    > > > #include <linux/mutex.h>
    > >
    > > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
    > > correct.
    > >
    >
    > ACK or Reviewed-by ?

    both if you want to, but John already picked it up for wireless-testing
    if I am not mistaken. So it is on its way into 2.6.32 somehow.

    Regards

    Marcel




    \
     
     \ /
      Last update: 2009-07-09 07:51    [W:0.021 / U:118.616 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site