Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] rework/fix is_single_threaded() | Date | Thu, 09 Jul 2009 14:01:03 +0100 |
| |
Oleg Nesterov <oleg@redhat.com> wrote:
> Unless David replies.
Sorry, I missed the last three messages.
> David, do you still dislike ->mmap_sem? I didn't see other objections, > and again, imho tasklist_lock is worse.
My main objection to taking mmap_sem is that it restricts where the function can be used. It can't, for example, be called by anyone holding a spinlock. Furthermore, the more locks, the more chance of someone accidentally deadlocking something.
But apart from that, go for it.
David
| |