Messages in this thread | | | Date | Thu, 9 Jul 2009 19:27:52 +0900 | Subject | Re: [PATCH 5/5] add NR_ANON_PAGES to OOM log | From | Minchan Kim <> |
| |
On Thu, Jul 9, 2009 at 4:20 PM, KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> wrote: >> > On Mon, 6 Jul 2009, Minchan Kim wrote: >> > >> > > Anyway, I think it's not a big cost in normal system. >> > > So If you want to add new accounting, I don't have any objection. :) >> > >> > Lets keep the counters to a mininum. If we can calculate the values from >> > something else then there is no justification for a new counter. >> > >> > A new counter increases the size of the per cpu structures that exist for >> > each zone and each cpu. 1 byte gets multiplies by the number of cpus and >> > that gets multiplied by the number of zones. >> >> OK. I'll implement this idea. > > Grr, sorry I cancel this opinion. Shem pages can't be calculated > by minchan's formula. > > if those page are mlocked, the page move to unevictable lru. then > this calculation don't account mlocked page. However mlocked tmpfs pages > also make OOM issue.
Absolutely. You're right. But In my opinion, mlocked shmem pages are important ? Now we care only number of unevictable pages but don't care what kinds of pages there are in unevictable list.
What we need is to decode OOM more easily. I think what kinds of pages there area unevictable lur list is not important.
-- Kind regards, Minchan Kim
| |