Messages in this thread | | | Date | Thu, 09 Jul 2009 09:47:50 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 3/4] block: implement mixed merge of different failfast requests |
| |
Hello,
Boaz Harrosh wrote: >> @@ -1165,6 +1165,7 @@ static int __make_request(struct request_queue *q, struct bio *bio) >> const unsigned short prio = bio_prio(bio); >> const int sync = bio_sync(bio); >> const int unplug = bio_unplug(bio); >> + const unsigned int ff = bio->bi_rw & REQ_FAILFAST_MASK; > > Perhaps a bio_fail_fast(bio) > and also an blk_failfast(rq).
Me not being a big fan of those simple accessors, I want to avoid adding those especially the use of bio ones are mostly confined to block layer proper.
Thanks.
-- tejun
| |