lkml.org 
[lkml]   [2009]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] block: implement mixed merge of different failfast requests
Hello,

Boaz Harrosh wrote:
>> @@ -1165,6 +1165,7 @@ static int __make_request(struct request_queue *q, struct bio *bio)
>> const unsigned short prio = bio_prio(bio);
>> const int sync = bio_sync(bio);
>> const int unplug = bio_unplug(bio);
>> + const unsigned int ff = bio->bi_rw & REQ_FAILFAST_MASK;
>
> Perhaps a bio_fail_fast(bio)
> and also an blk_failfast(rq).

Me not being a big fan of those simple accessors, I want to avoid
adding those especially the use of bio ones are mostly confined to
block layer proper.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-07-09 02:51    [W:0.081 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site