lkml.org 
[lkml]   [2009]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [rfc][patch 4/4] fs: tmpfs, ext2 use new truncate
    On Wed, Jul 08, 2009 at 01:14:20PM +0200, Jan Kara wrote:
    > On Wed 08-07-09 08:53:27, Nick Piggin wrote:
    > > On Tue, Jul 07, 2009 at 12:38:29PM -0400, Christoph Hellwig wrote:
    > > > We can't move this to the caller easily. ext2_delete_inode gets
    > > > called for all inodes, but we only want to go on truncating for the
    > > > limited set that passes this check.
    > >
    > > Hmm, shouldn't they have no ->i_blocks in that case?
    > Not necessarily. Inode can have extended attributes set and those can
    > be stored in a special block which is accounted in i_blocks.

    OK fair enough. But I don't know if all those checks are
    realy appropriate. For example an IS_APPEND inode should
    be able to have its blocks trimmed off if a write fails.



    \
     
     \ /
      Last update: 2009-07-08 14:25    [W:2.346 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site