Messages in this thread | | | Subject | Re: [RFC PATCH 2/3] kmemleak: Add callbacks to the bootmem allocator | From | Catalin Marinas <> | Date | Wed, 08 Jul 2009 11:02:35 +0100 |
| |
On Wed, 2009-07-08 at 11:46 +0200, Johannes Weiner wrote: > On Tue, Jul 07, 2009 at 11:09:46PM +0100, Catalin Marinas wrote: > > > It seems that alloc_bootmem_core() is central to all the bootmem > > allocations. Is it OK to place the kmemleak_alloc hook only in this > > function? > > > > diff --git a/mm/bootmem.c b/mm/bootmem.c > > index 5a649a0..74cbb34 100644 > > --- a/mm/bootmem.c > > +++ b/mm/bootmem.c > > @@ -520,6 +520,7 @@ find_block: > > region = phys_to_virt(PFN_PHYS(bdata->node_min_pfn) + > > start_off); > > memset(region, 0, size); > > + kmemleak_alloc(region, size, 1, 0); > > return region; > > } > > Yes, that should work.
Thanks. May I add your Acked-by line to the final patch?
-- Catalin
| |