Messages in this thread | | | From | Parag Warudkar <> | Subject | Re: Possible memory leak in fs/sysfs/bin.c | Date | Mon, 6 Jul 2009 23:12:13 +0000 (UTC) |
| |
Hi
Catalin Marinas <catalin.marinas <at> arm.com> writes:
> --- a/fs/sysfs/bin.c > +++ b/fs/sysfs/bin.c > @@ -164,6 +164,7 @@ static ssize_t write(struct file *file, const char > __user *userbuf, > mutex_lock(&bb->mutex); > > memcpy(bb->buffer, temp, count); > + kfree(temp);
Does the kfree() need to be inside the mutex_lock? Otherwise looks OK to me.
Parag
| |