lkml.org 
[lkml]   [2009]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/10] writeback: support > 1 flusher thread per bdi
    Jens Axboe wrote:
    > +static struct bdi_work *bdi_alloc_work(struct super_block *sb, long nr_pages,
    > + enum writeback_sync_modes sync_mode)
    > +{
    > + struct bdi_work *work;
    > +
    > + work = kmalloc(sizeof(*work), GFP_ATOMIC);
    > + if (work)
    > + bdi_work_init(work, sb, nr_pages, sync_mode);
    >
    > - wb_start_writeback(&bdi->wb, sb, nr_pages, sync_mode);
    > + return work;
    > +}

    Since the caller of this function handles kmalloc failure gracefully,
    should we also pass __GFP_NOWARN flag to kmalloc() here, in order to
    avoid large and scary no-memory complaints?

    --
    Best Regards,
    Artem Bityutskiy (Артём Битюцкий)
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-06 14:23    [W:0.021 / U:1.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site