lkml.org 
[lkml]   [2009]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/3] dma-mapping:remove CONFIG_HAVE_DMA_ATTRS
From
On Sun, 5 Jul 2009 20:44:18 +0800
Ming Lei <tom.leiming@gmail.com> wrote:

> On Sun, 5 Jul 2009 13:19:36 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Saturday 04 July 2009, tom.leiming@gmail.com wrote:
> > > 2,Disabling CONFIG_HAVE_DMA_ATTRS may lead to a compile failure;
> >
> > I'm not sure I understand this point. CONFIG_HAVE_DMA_ATTRS tells
> > the common code whether the architecture understands dma attributes.
>
> If a new arch does not define CONFIG_HAVE_DMA_ATTRS but uses
> dma-mapping-common.h, it will lead to a compile failure.

Yeah, architectures that use dma-mapping-common.h need to define
CONFIG_HAVE_DMA_ATTRS because dma-mapping-common.h needs to handle
architectures that need CONFIG_HAVE_DMA_ATTRS.


Your idea doesn't sound good to me.

I think that it's better to define CONFIG_HAVE_DMA_ATTRS in the
consistent way; defining arch's Kconfig. Defining
CONFIG_HAVE_DMA_ATTRS in two different ways and inventing another
define such as ARCH_USE_DMA_MAPPING_COMMON is just confusing.


\
 
 \ /
  Last update: 2009-07-06 04:31    [W:1.987 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site