Messages in this thread | | | From | Ohad Ben-Cohen <> | Date | Fri, 31 Jul 2009 14:10:24 +0300 | Subject | Re: [PATCH] sdio: add CD disable support |
| |
Hi David,
Thank you for your comments.
On Thu, Jul 30, 2009 at 3:54 PM, David Vrabel<david.vrabel@csr.com> wrote: > Platforms may rely on the card's pull-up and not fit/configure an > external one. There may need to be a way for host controller drivers to > say this and prevent the disabling of the card's DAT3 pull-up.
Currently the only way to really disable the CD using this patch is by setting the disable_cd bit on for a specific controller. We are doing so for a specific controller to which an embedded sdio device is wired, on certain boards. This is done using the embedded_sdio's .cccr field, which is used instead of reading the card's cccr. So as you correctly noted, card has no say here.
> The first sentence of this comment doesn't make sense.
Fixed;
I'll follow-up with a correction of the patch and will appreciate your review.
Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |