Messages in this thread | | | Date | Thu, 30 Jul 2009 14:29:06 -0700 (PDT) | Subject | Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of IP_VS_ERR and friends | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Tue, 28 Jul 2009 13:56:55 -0700
> On Tue, 2009-07-28 at 22:35 +0200, Hannes Eder wrote: >> Since pr_err and friends is used instead of printk there is not point >> in keeping IP_VS_ERR and friends. >> + pr_err("Schedule: port zero only supported " >> + "in persistent services, " >> + "check your ipvs configuration\n"); > > You might consider ignoring the checkpatch 80 char limit here > and consolidate the message into a single string.
I don't think this is such a big deal.
>> - IP_VS_ERR("ip_vs_svc_unhash(): request for unhash flagged, " >> - "called from %p\n", __builtin_return_address(0)); >> + pr_err("ip_vs_svc_unhash(): request for unhash flagged, " >> + "called from %p\n", __builtin_return_address(0)); > > Maybe use something like: > "%s(): <foo> called from %pf", > __func__, __builtin_return_address(0) >
However I do agree that this change should be made.
| |