[lkml]   [2009]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] [mtd] fixed faulty check
    Stoyan Gaydarov wrote:
    >>> We have to and of_flash_remove() takes care of it.
    > Does this mean that the original patch is fine or does it still need the
    > kfree? From what i understand when going to err_out it will take care of
    > info using of_flash_remove() so then it is not needed in the if check.

    The original patch was fine but it leaked info. of_flash_remove() does the
    cleanup of info but only if it is part of driver's data (after the
    of_flash_remove()). So you have to call dev_set_drvdata(&dev->dev, info)
    earlier, after the kzalloc() to save the data or else there is no clean

    > -Stoyan


     \ /
      Last update: 2009-07-30 16:57    [W:0.020 / U:21.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site