Messages in this thread | | | From | vimal singh <> | Date | Thu, 30 Jul 2009 20:04:22 +0530 | Subject | Re: [PATCH] [mtd] fixed faulty check |
| |
On Thu, Jul 30, 2009 at 7:55 PM, Stoyan Gaydarov<sgayda2@uiuc.edu> wrote: > vimal singh wrote: > > On Thu, Jul 30, 2009 at 7:17 PM, Sebastian Andrzej > Siewior<bigeasy@linutronix.de> wrote: > > > vimal singh wrote: > > > What if you go to 'err_out' due to some other error?? Do not you need > to free 'info'? > > > We have to and of_flash_remove() takes care of it. > > > > > Does this mean that the original patch is fine or does it still need the > kfree? From what i understand when going to err_out it will take care of > info using of_flash_remove() so then it is not needed in the if check.
Yes. But I think, you should still correct freeing 'mtd_list' in the label, when you jump there even before memory gets allocated for that.
-vimal
> > -Stoyan > > that's correct... > > > > The initial patch would be shorter if > dev_set_drvdata(&dev->dev, info); > would be moved prior the kzalloc() > > Sebastian > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |