lkml.org 
[lkml]   [2009]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
    Date

    Hi,

    On Thursday 30 July 2009 09:43:49 Jonathan Woithe wrote:
    > Hi Bart
    >
    > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    > > Subject: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
    > >
    > > This takes care of the following entries from Dan's list:
    > >
    > > drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning: variable derefenced before check 'fujitsu'
    > > drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning: variable derefenced before check 'fujitsu'
    >
    > I'd rather keep the test for a non-null fujitsu in there, but obviously it's
    > kind of pointless doing it after the first dereference. Since this fixup
    > overlaps with the one previously discussed with Julia I've taken the liberty

    They are on top of Julia's patch (sorry I forgot to mention it)..


    \
     
     \ /
      Last update: 2009-07-30 14:13    [W:0.029 / U:30.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site