Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH repost 1/4] V4L: radio-si470x, fix lock imbalance | Date | Fri, 3 Jul 2009 22:51:33 +0200 |
| |
There is one path with omitted unlock in si470x_fops_release. Fix that.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com> --- drivers/media/radio/radio-si470x.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio/radio-si470x.c index 640421c..46d2163 100644 --- a/drivers/media/radio/radio-si470x.c +++ b/drivers/media/radio/radio-si470x.c @@ -1200,7 +1200,7 @@ static int si470x_fops_release(struct file *file) video_unregister_device(radio->videodev); kfree(radio->buffer); kfree(radio); - goto done; + goto unlock; } /* stop rds reception */ @@ -1213,9 +1213,8 @@ static int si470x_fops_release(struct file *file) retval = si470x_stop(radio); usb_autopm_put_interface(radio->intf); } - +unlock: mutex_unlock(&radio->disconnect_lock); - done: return retval; } -- 1.6.3.2
| |