Messages in this thread | | | Date | Fri, 3 Jul 2009 11:06:20 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] vt: add an event interface |
| |
> Your method leads to stuff like this in a recent commit:
Which is a cut and paste of code from the originals into the helper.
> Also note the inconsistent printk-ing lines, mutiliated by line > warps. The use of pr_warning() would solve it:
Send patches if it bugs you that much. It's rather lower on my agenda than pressing things like "if I do xyz to a tty then 2.6.29 crashes" grade sutff.
Alan
| |