lkml.org 
[lkml]   [2009]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vt: add an event interface
> Just a side-note, please run new patches through 
> scripts/checkpatch.pl:
>
> total: 4 errors, 2 warnings, 0 checks, 294 lines checked

Given the code doesn't currently *work* yet but is a first draft its
hardly important and there are better uses of time than playing
checkpatch policeman.

> - the copy_from_user() in vt_event_wait_ioctl() could be shortened
> if we didnt pass in an unsigned long (which is pointless anyway).
> The cast to void __user * should be done in the ioctl
> demultiplexer vt_ioctl(), and the ioctl ugliness should not
> invade cleaner child functions such as vt_event_wait_ioctl().
>
> - same for vt_event_wait_ioctl() - it passes in a type damaged by
> ioctl's limitations. Such type limitations and ioctl demuxing
> artifacts should be kept local to vt_ioctl().

That had already occurred to me. The events should also become a mask so
you can wait for several at once. What I wanted to know was whether such
an interface actually meets Lennart's requirements.

Alan


\
 
 \ /
  Last update: 2009-07-03 11:09    [W:0.160 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site