lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3 -mm] generic-ipi: fix hotplug_cfd()
    On Wed, 29 Jul 2009 15:53:13 +0800
    Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:

    > Use CONFIG_HOTPLUG_CPU, not CONFIG_CPU_HOTPLUG
    >
    > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
    > ---
    > kernel/smp.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/kernel/smp.c b/kernel/smp.c
    > index bf9f18b..1b5fd2e 100644
    > --- a/kernel/smp.c
    > +++ b/kernel/smp.c
    > @@ -54,7 +54,7 @@ hotplug_cfd(struct notifier_block *nfb, unsigned long action, void *hcpu)
    > return NOTIFY_BAD;
    > break;
    >
    > -#ifdef CONFIG_CPU_HOTPLUG
    > +#ifdef CONFIG_HOTPLUG_CPU
    > case CPU_UP_CANCELED:
    > case CPU_UP_CANCELED_FROZEN:
    >

    Dammit, that mistake is easy to make. We should have used #if from day
    one, not #ifdef. Oh well.

    What's the impact of this bug? Do we think the fix should be present
    in 2.6.31? 2.6.30.x?



    \
     
     \ /
      Last update: 2009-07-30 01:31    [W:3.046 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site