Messages in this thread | | | From | Peter Feuerer <> | Subject | Re: [PATCH] acerhdf: convert to dev_pm_ops | Date | Wed, 29 Jul 2009 09:25:51 +0200 |
| |
Hi Boris,
Borislav Petkov writes:
> On Tue, Jul 28, 2009 at 3:25 PM, Peter Feuerer<peter@piie.net> wrote: > > [..] > >>> That's not a reason for keeping code in the kernel and raising bloat >>> levels unnecessarily. If the driver doesn't need to do anything on >>> resume, then no function is needed. >> >> I don't think the verbose message is useless. If an user has a problem >> with suspend / hibernate I can just ask him to load the module with >> verbose=1 and dmesg tells whether the module is waking up or not. > > Since the driver doesn't do anything upon resume, it _is_ _going_ to > resume just fine. If not, then the problem is located somewhere else, > i.e. you can safely assume that you are resuming ok. Also, it's not like > this is the only verbose printk you have in the driver to not be able to > follow what's going on...
Ok, I think you are right. So we will remove the resume functionality and keep just the suspend + freeze calls?
Btw, should I resend the 0.5.13 → 0.5.16 patch splitted up, so that Len can apply them?
kind regards, --peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |