lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kdesu broken
>  		tty_ldisc_deref(ld);
> + tty_ldisc_halt(tty);
> + tty_ldisc_wait_idle(tty);

Needs to be
mutex_lock(&tty->ldisc_mutex);
if (tty->ldisc)
....
}
mutex_unlock(&tty->ldisc_mutex)

We can't wait for the reference to go away if we hold one, and if we
don't hold one the ldisc reference might go away during the hangup if we
close()

Odds of hitting it minimal however. Or maybe we need a smarter
tty_ldisc_wait_self_idle(ld) ?



\
 
 \ /
  Last update: 2009-07-29 18:41    [W:0.118 / U:6.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site