lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 14/71] USB: EHCI: use the new clear_tt_buffer interface
On Wed, Jul 29, 2009 at 10:24:55AM -0400, Alan Stern wrote:
> On Wed, 29 Jul 2009, Greg KH wrote:
>
> > On Wed, Jul 29, 2009 at 09:56:31AM -0400, Alan Stern wrote:
> > > On Tue, 28 Jul 2009, Greg KH wrote:
> > >
> > > > 2.6.30-stable review patch. If anyone has any objections, please let us know.
> > > >
> > > > ------------------
> > > >
> > > > From: Alan Stern <stern@rowland.harvard.edu>
> > > >
> > > > commit 914b701280a76f96890ad63eb0fa99bf204b961c upstream.
> > > >
> > > > This patch (as1256) changes ehci-hcd and all the other drivers in the
> > > > EHCI family to make use of the new clear_tt_buffer callbacks. When a
> > > > Clear-TT-Buffer request is in progress for a QH, the QH is not allowed
> > > > to be linked into the async schedule until the request is finished.
> > > > At that time, if there are any URBs queued for the QH, it is linked
> > > > into the async schedule.
> > >
> > > Greg, can we hold off on applying this patch to the stable tree?
> > >
> > > It turns out that this change causes a WARN_ON to trigger in some
> > > circumstances, and the proposed patch to fix _that_ hasn't yet been
> > > submitted to the mainline because a few people have reported that it
> > > leaks DMA pool memory. So far there hasn't been much progress in
> > > tracking this down.
> >
> > Sure, I'll drop it. Should I also drop the patch before this one as
> > well, which was there only because this patch needed it?
>
> In terms of functionality, it doesn't matter. I guess you might as
> well.

Ok, I've now dropped them both.

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-07-29 16:49    [W:0.119 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site