lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] power_supply: get_by_name and set_charged functionality
Daniel Mack wrote:
> On Wed, Jul 29, 2009 at 11:29:48AM +0100, Ian molton wrote:
>> Looks ok. the only comment I have right now is that the comment doesnt
>> quite match the patch - it suggests that the patch doesnt include the
>> power_supply_set_battery_charged() function, when it does in fact.
>
> The subject mentions it, and the body references it again. Hmm. Anyway.
> Want me to resend? Or could the commiter add another sentence to point
> that out? I think that would be Anton, as he agreed to pick all the
> other patches I recently sent in.

I'm not that fussed - you just seemed to want feedback, so I had a read ;-)

If you change it, I'd write something like:

This adds a function that indicates that a battery is fully charged. It
also includes functions to get a power_supply device from the class of
registered devices by name reference. These can be used to find a
specific battery to call power_supply_set_battery_charged() on.

Some battery drivers might need this information to calibrate
themselves.

Or something.


\
 
 \ /
  Last update: 2009-07-29 14:47    [W:0.907 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site