Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] kdesu broken | Date | Tue, 28 Jul 2009 05:38:24 +0900 |
| |
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Tue, 28 Jul 2009, OGAWA Hirofumi wrote: >> >> If I read that part of emacs correctly, it seems to be assuming the data >> was already sent to master side if the child process was exited. > > That sounds like a rather obvious assumption. > > Aren't pty's flushing the data at flush() time? Which should be happening > when the child process exits and closes the pty slave.
For tty, I guess yes. However, now, pty is pushing the data to other side by background, I'm not sure at all though, I guess ppp is requiring it.
> So at what point do we just admit that the commit that caused all this was > a buggy pile of sh*t and just revert it?
Also, I'm not sure though, I guess it depends on the bug which was fixed by the commit.
I don't know about ppp problem at all. So, personally I'm ok either way - we revert it and try to fix this for next merge window, or continue to fix this for a while.
Alan-san?
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |