lkml.org 
[lkml]   [2009]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: slqb enables interrupts very early
Sebastian Andrzej Siewior wrote:
> I've checkout slab-2.6/linux-next and noticed that the interrupts are
> enabled very early by accident. Please look at the following call stack:
>
> start_kernel()
> kmem_cache_init()
> kmem_cache_open()
> down_write(&slqb_lock);
> __down_write()
> __down_write_nested()
>
> Now, __down_write_nested() protects its internal structure the follwing
> way:
> spin_lock_irq(&sem->wait_lock);
> ...
> spin_unlock_irq(&sem->wait_lock);
>
> so once we return, we return with interrupts on.

Indeed. Nick, do we need to take ->slqb_lock in kmem_cache_open()? A
quick read on the code suggests that we could just drop it.

Pekka


\
 
 \ /
  Last update: 2009-07-27 09:47    [W:0.040 / U:2.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site