Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [Regression] kdesu broken | Date | Mon, 27 Jul 2009 21:46:07 +0900 |
| |
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>> + spin_lock_irqsave(&pair->buf.lock, flags); >> + pair->packet = 0; > > I worried "pair->packet = 0" when I'm thinking this. I guess it would be > changed more early than before. Is it ok?
Ah, maybe, this is ok. Because n_tty_read() checks it, so, I guess there is no big difference with before change.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |