Messages in this thread | | | Date | Sun, 26 Jul 2009 17:00:54 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH 0/2] ZERO PAGE again v4. |
| |
On Thu, 23 Jul 2009, KAMEZAWA Hiroyuki wrote: > On Wed, 22 Jul 2009 17:12:45 -0700 > Andrew Morton <akpm@linux-foundation.org> wrote: > > On Thu, 23 Jul 2009 08:51:37 +0900 > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > > > On Thu, 16 Jul 2009 18:01:34 +0900 > > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > > > > > > > > Rebased onto mm-of-the-moment snapshot 2009-07-15-20-57. > > > > And modifeied to make vm_normal_page() eat FOLL_NOZERO, directly. > > > > > > > > Any comments ?
Sorry, I've been waiting to have something positive to suggest, but today still busy with my own issues (handling OOM in KSM).
I do dislike that additional argument to vm_normal_page, and feel that's a problem to be solved in follow_page, rather than spread to every other vm_normal_page user.
Does follow_page even need to be using vm_normal_page? Hmm, VM_MIXEDMAP, __get_user_pages doesn't exclude that.
I also feel a strong (but not yet fulfilled) urge to check all the use_zero_page ignore_zero stuff: which is far from self-evident.
Hugh
| |