Messages in this thread | | | Date | Sun, 26 Jul 2009 17:46:49 +0200 | Subject | Re: [PATCH] fs/notify/inotify: decrement user inotify count on close | From | Alex Riesen <> |
| |
On Thu, Jul 2, 2009 at 14:14, Eric Paris<eparis@redhat.com> wrote: > On Wed, 2009-07-01 at 21:56 -0700, Keith Packard wrote: >> The per-user inotify_devs value is incremented each time a new file is >> allocated, but never decremented. This led to inotify_init failing after a >> limited number of calls. >> >> Signed-off-by: Keith Packard <keithp@keithp.com> > > Thanks, I will push to Linus later today, sorry about the regression! >
Hmm... Either the patch wasn't enough, or it was broken again. On v2.6.31-rc4, I get this:
# echo 10 >/proc/sys/fs/inotify/max_user_watches # inotifywatch -r /usr/lib # generate watches up to the limit Establishing watches... Failed to watch /bin; upper limit on inotify watches reached! Please increase the amount of inotify watches allowed per user via `/proc/sys/fs/inotify/max_user_watches'. # inotifywatch /bin/true # just one watch for just one file
AFAIU, the second inotifywatch should work, and the watches of the first, failed, run must be cleared.
| |