Messages in this thread Patch in this message | | | Date | Fri, 24 Jul 2009 09:39:10 +0200 | From | Michal Simek <> | Subject | generic uaccess.h |
| |
Hi Arnd,
I have just look at asm-generic uaccess.h and there is one thing which seems to me wrong.
For put_user macro - you use __copy_to_user but you have for 64bit case ifdef CONFIG_64BIT but look at fs/eventfd: eventfd_read function. At least for this function(syscall) is necessary "return" 64bit value on 32bit machines too. IMHO that ifdef CONFIG_64BIT shouldn't be there.
What do you think? If you agree with me, I'll generate proper patch with description.
Thanks, Michal
diff --git a/include/asm-generic/uaccess.h b/include/asm-generic/uaccess.h index b218b85..bbbb983 100644 --- a/include/asm-generic/uaccess.h +++ b/include/asm-generic/uaccess.h @@ -119,11 +119,9 @@ static inline __must_check long __copy_to_user(void __user case 4: *(u32 __force *)to = *(u32 *)from; return 0; -#ifdef CONFIG_64BIT case 8: *(u64 __force *)to = *(u64 *)from; return 0; -#endif default: break; }
-- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854
| |