lkml.org 
[lkml]   [2009]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] veth: don't free priv->status until dev->destructor (v2)
    On Fri, 26 Jun 2009 11:24:18 -0500
    "Serge E. Hallyn" <serue@us.ibm.com> wrote:

    > Based on the commit msg on ae0e8e82205c903978a79ebf5e31c670b61fa5b4, it looks

    > ether_setup(dev);
    > @@ -306,7 +320,7 @@ static void veth_setup(struct net_device *dev)
    > dev->netdev_ops = &veth_netdev_ops;
    > dev->ethtool_ops = &veth_ethtool_ops;
    > dev->features |= NETIF_F_LLTX;
    > - dev->destructor = free_netdev;
    > + dev->destructor = veth_dev_free;
    >

    This is still going to oops if sysfs statistics referenced
    after module unload because module is unloaded (code is gone)
    and veth_dev_free no longer exists.

    I'll respin the original patch (using free_netdev) and fix
    the statistics complaint.


    \
     
     \ /
      Last update: 2009-07-24 21:49    [W:0.035 / U:64.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site